[Enhencement] - Unused code being eliminated #2713
Conversation
… tests that broke integration test locally
VindeeR
added
enhancement
| if 'password' not in kwargs: | ||
| kwargs['password'] = password | ||
| kwargs['look_for_keys'] = False | ||
| kwargs['allow_agent'] = False |
There was a problem hiding this comment.
This is harmless, and Erick's environment has something different in his ssh-agent and/or ssh config that prevents him from running the tests. It shouldn't cause any issues to others here as we don't rely on ssh-agent or config, and instead connect using the password directly for the Docker container.
… tests that broke integration test locally
|
Found one place where I think test_fs_operations could be sharing the same directory among tests. Fixed that one, let's see what fails next. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2713 +/- ##
==========================================
+ Coverage 70.50% 70.56% +0.05%
==========================================
Files 86 86
Lines 19805 19746 -59
Branches 3849 3828 -21
==========================================
- Hits 13964 13933 -31
+ Misses 4852 4824 -28
Partials 989 989
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Commit removing unused code spread over Autosubmit and adding fix for integration tests that were broke test locally
Adding @kinow to this PR since he wants to detach some unused code from a branch he's working on
Check List
CONTRIBUTING.md.pyproject.toml.CHANGELOG.mdif this is a change that can affect users.Closes #1234).